Changeset e1752222d4ab14465888fcefbbb5b1751865da56

Timestamp:

23/04/11 22:12:18 (2 years ago)

Author:

Matias De la Puente <mfpuente.ar@…>

Children:

b077dbd65cab68e8f2bd96e1f8678c40cbb8a93c

Parents:

19b0a7cc6e80e13ec0384081c823ed704723ac73

git-committer:

Matias De la Puente <mfpuente.ar@…> (23/04/11 22:12:18)

Message:

Hide 'extra options' expander when there's no extra options

Files:

• gtkfrontend/optionsview.vala (modified) (3 diffs)
• libi4uccore/optionslogic.vala (modified) (2 diffs)
• libi4uccore/optionsview.vala (modified) (1 diff)

gtkfrontend/optionsview.vala

@@ -27 +27 @@
         private VBox _extra_options_vbox = new VBox (false, 5);
         
+        public bool extra_options_visible { set; get; }
+        
         public OptionsView ()
         {
@@ -36 +38 @@
                 pack_start (_options_vbox, false, false, 5);
                 pack_end (_extra_options_expander, false, false, 5);
+                
+                bind_property ("extra-options-visible", _extra_options_expander, "visible", BindingFlags.BIDIRECTIONAL);
         }
         
@@ -66 +70 @@
                 }
                 if (most_used)
+                {
                         _options_vbox.pack_start (option, false, false, 4);
+                        _options_vbox.show_all ();
+                }
                 else
+                {
                         _extra_options_vbox.pack_start (option, false, false, 4);
-                show_all ();
+                        _extra_options_vbox.show_all ();
+                }
                 return option;
         }

libi4uccore/optionslogic.vala

@@ -40 +40 @@
         {
                 _view = view;
+                _view.extra_options_visible = false;
         }
         
@@ -58 +59 @@
                         _view.clear_options ();
                 }
+                _view.extra_options_visible = false;
                 foreach (var option in _options)
                 {
                         var option_view = _view.add_option (option.name, option.locale_label, option.value_type, option.optional, option.most_used);
+                        
+                        if (!option.most_used)
+                                _view.extra_options_visible = true;
                         
                         // Add a detailed tooltip

libi4uccore/optionsview.vala

@@ -22 +22 @@
 public interface I4uc.Core.OptionsView : GLib.Object
 {
+        public abstract bool extra_options_visible { set; get; }
+        
         public abstract OptionView add_option (string name, string label, string value_type, bool optional, bool most_used);
         public abstract void clear_options ();